Write new blocks and states to the database atomically #1285
Conversation
| store.store_cold_state(&state_root, &state)?; | ||
| let mut ops: Vec<KeyValueStoreOp> = Vec::new(); | ||
| store.store_cold_state(&state_root, &state, &mut ops)?; | ||
| store.cold_db.do_atomically(ops)?; |
There was a problem hiding this comment.
This strikes me as odd when maybe the whole migration should be 2 DB transactions (copy to freezer, delete from hot), but I'm happy to postpone thinking about that until later.
There was a problem hiding this comment.
I overlooked this one. Happy to correct this in a separate PR.
| ) -> Result<(), Error> { | ||
| let total_timer = metrics::start_timer(&metrics::BEACON_STATE_WRITE_TIMES); |
There was a problem hiding this comment.
This timer should probably stay for now
There was a problem hiding this comment.
It would be meaningless. The PR makes it so that the actual db write is executed at some other place in the code, during the call to do_atomically().
There was a problem hiding this comment.
Oh, of course! Lets delete BEACON_STATE_WRITE_TIMES from beacon_node/store/src/metrics.rs then, as it's now unused. I've also opened #1307 to track the state of the store metrics
michaelsproul
added
waiting-on-author
adaszko
force-pushed
the
master
branch
2 times, most recently
from
ccd4307
to
e341c55
Compare
adaszko
added
ready-to-squerge
and removed
waiting-on-author
|
@paulhauner I've just tested this on Altona and it's performing well 💯 If you're OK to merge it I'll go ahead and merge tomorrow |
(Mostly) fixes #692